New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable permissive `max-len` and `max-lines` as warning #84

Open

fregante wants to merge 1 commit into main from max

Member

fregante commented Nov 17, 2023 •

edited

Closes Reintroduce "length" rules to catch excess xo#738

I think it might make sense to enable them as warning to look at the pushback without creating too much trouble.

I think 200ch is a good upper limit, but I'm not sure about "1000 lines", especially in files with inline documentation and licensing.


          max len max lines

08364af

Member

sindresorhus commented Nov 17, 2023

I think 2000 lines is too little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment