New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CN: Consistency cleanup #2793
base: dev
Are you sure you want to change the base?
CN: Consistency cleanup #2793
Conversation
Do you know how compile-time checks are optimized by the compiler? They are essentially zero-cost. |
Same goes for all |
OK, following those rules, I've gone the other direction then. Consistency is when everything is done the same way, whichever way that is. The latest commit pushes everything back the other direction instead (use |
f6ef5af
to
d414525
Compare
d414525
to
6252422
Compare
0d46d7f
to
735e6e9
Compare
735e6e9
to
862280f
Compare
props.isHeavy()
logic within the_gr_
functions as they are no longer called unless alreadyCN_GR_[0-5]
IS_CN_HEAVY_XHV
to match existingIS_CN_HEAVY_TUBE
and use it everywhere the long-form test was usedIS_HEAVY
toIS_CN_HEAVY
to better match theIS_CN_HEAVY_(TUBE|XHV)
IS_CN_HEAVY
the same everywhereprops.isHeavy()
was called separatelyIS_CN_HEAVY
is also defined everywhereCN_STEP4
macro was used, as itsprops.isHeavy()
was changedcn_vaes_enabled
tests for slightly improved readability, and allows to not validate the other bools unless VAES is available (now in roughly likelihood-to-be-false and importance order)Tested compile, and valid accepts for
cn-heavy/xhv
andghostrider
but I do not have any VAES capable rigs, so it still needs a diligence proof test on something that does have it. Also don't have any pools to test thecn-heavy/0
orcn-heavy/tube
but I think thecn-heavy/xhv
test proves those by association.Should be a tiny bit nicer since all these are validated once into constexpr-bool's the same way everywhere.