Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pause-on-active for Linux and FreeBSD #2220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement pause-on-active for Linux and FreeBSD #2220

wants to merge 1 commit into from

Conversation

In-line
Copy link

@In-line In-line commented Mar 31, 2021

No description provided.

@SChernykh
Copy link
Contributor

It's not a good idea to bring X dependencies, making compilation harder just for this small insignificant feature. In many cases xmrig runs on a server without X installed.

@In-line
Copy link
Author

In-line commented Mar 31, 2021

@SChernykh We can make it optional feature.

@In-line
Copy link
Author

In-line commented Mar 31, 2021

I can change the code to load necessary libraries with dlopen

@xmrig
Copy link
Owner

xmrig commented Mar 31, 2021

This feature can be added only if it does not require X11 to build the miner.
Thank you.

@In-line
Copy link
Author

In-line commented Mar 31, 2021 •
edited

@xmrig I submitted second version #2222 with build-time optional X11 and runtime optional X11 libs.

So we can build with X11 headers present and then ship it for servers & gui desktops as single executable.

Users who don't care about X11, can build without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@In-line @SChernykh @xmrig