xform priority fallback #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of failing the chain build if the highest priority xform plugins can't handle a format, fall back to the next highest priority plugin at each point in the chain, so that a low priority plugin can be used in the event that the normal high priority plugin can't handle a given format.
This is required for it to work with the xform priority change, which seeks back to the start of the data before creating each xform.
|
Breaks the xform tests, install libcunit and rebuild and you'll automatically run the test suite. Failure: |
This results in the xform tests passing.
|
Sorry, wasn't aware of how the tests worked. Updated the code so the tests now pass. Had to change the test plugin to report priority 50 since the existing priority of 0 means the plugin is disabled, but the tests are otherwise unchanged. The remaining CI build failures look like they aren't related to this patch. |
|
@Malvineous yep, macOS build is due to some cython change, and the analysis build tries to upload new documentation, which should be gated to main master branch. I'll have a look at this tonight I hope. Ping me if I'm slow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further to the reply from nesciens on xmms2-devel on 2016-05-16, here is a small amendment to the XMMS2 xform priority system, to allow multiple xform plugins to handle the same file type, with higher priority plugins being tried, and if they fail to handle the format, falling back to lower priority plugins.
I will post a message to xmms2-devel now about this change, in case it is easier to discuss there.