Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cpu usage #560

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enable cpu usage #560

wants to merge 3 commits into from

Conversation

tejaswivg
Copy link

These changes fix some issues I had when torch is used without cuda (cpu only).

@Splendide-Imaginarius
Copy link

Splendide-Imaginarius commented Jan 30, 2023

I implemented #561 as an alternative approach (wasn't intentionally duplicating your effort; I wrote my PR last week before yours was submitted). I like your approach of defaulting to CPU mode if CUDA isn't available, but I think it would be desirable to allow the user to explicitly choose CPU even if CUDA is available (as my PR does). Feel free to borrow pieces of my PR; seems desirable to combine the respective strengths of both PR's.

@tejaswivg
Copy link
Author

I implemented #561 as an alternative approach (wasn't intentionally duplicating your effort; I wrote my PR last week before yours was submitted). I like your approach of defaulting to CPU mode if CUDA isn't available, but I think it would be desirable to allow the user to explicitly choose CPU even if CUDA is available (as my PR does). Feel free to borrow pieces of my PR; seems desirable to combine the respective strengths of both PR's.

@xinntao any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants