Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug for the inference of gray image #484

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DsLipku
Copy link

@DsLipku DsLipku commented Oct 25, 2022

#483
repeat the gray channels to three channels before use GFPGAN to enhance face.

@Splendide-Imaginarius
Copy link

I can confirm that 08bb631 fixes the error. However, I suspect that this fix should be submitted to GFPGAN rather than this repo, so that other downstream projects benefit from the fix. Also, I do not understand why img_mode is set to 'L'. That variable doesn't look like it's used anywhere except checking for 'RGBA', and I'm pretty sure its value will never be 'RGBA' when the grayscale code path is reached, so I think that line can simply be removed from this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants