#470 Change default find highlight color #481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,7 +93,8 @@ extension Theme { | |||
| let caret = NSColor(jsonRgbaColor: json["caret"] as? [String: Any] ?? [:]) | |||
| let line_highlight = NSColor(jsonRgbaColor: json["line_highlight"] as? [String: Any] ?? [:]) | |||
|
|
|||
| let find_highlight: NSColor? = NSColor(jsonRgbaColor: json["find_highlight"] as? [String: Any] ?? [:]) | |||
| // Use default find highlight color instead of theme's find_highlight value | |||
| let find_highlight: NSColor? = Theme.defaultFindHighlightColor | |||
There was a problem hiding this comment.
I think if the theme specifies a color for find highlights, then it's ok to use that color instead of forcing the default yellow.
There was a problem hiding this comment.
Sure, I'm also bit not clear on expected behavior. I will wait for @cmyr's clarification #470 (comment)
Issue: xi-editor#470 Find highlight color defaults to red color instead it should use system's default find highlight color(NSColor.findHighlightColor) Fix: * Theme has new static variable representing default find highlight color * Other find highlight colors are generated from the hue of default find highlight color * Find highlight color specified by xi-editor on theme_changed event is ignored
mohanio
force-pushed
the
470-set-default-find-highlight-color-to-system-default
branch
from
3ad5d49
to
df6d765
Compare
Updated the commit subject and message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue:
#470
Find highlight color defaults to red color instead it should use system's default find highlight color(NSColor.findHighlightColor)
Fix:
Related Issues
closes #470
Checklist
Example:
Review Checklist