Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default find highlight color #470

Open
cmyr opened this issue Jun 24, 2019 · 2 comments · May be fixed by #481
Open

Change default find highlight color #470

cmyr opened this issue Jun 24, 2019 · 2 comments · May be fixed by #481
Labels
easy enhancement help wanted

Comments

@cmyr
Copy link
Member

cmyr commented Jun 24, 2019 •
edited

Currently find highlights are red by default. We should default to NSColor.findHighlightColor or something? There may also be a color defined in the theme that we can use. (The motivation for not using the colors in the theme is that we support multiple 'find groups' with different colors, and want these to be distinct, but I think we should default to an appropriate color for the first group.
mohanio pushed a commit to mohanio/xi-mac that referenced this issue Oct 19, 2019
https://github.com/xi-editor/xi-mac/issues/470
3ad5d49 
Issue:
Find highlight color defaults to red color instead it should use system's default find highlight color(NSColor.findHighlightColor)

Fix:
* Theme has new static variable representing default find highlight color
* Other find highlight colors are generated from the hue of default find highlight color
* Find highlight color specified by xi-editor on theme_changed event is ignored
@mohanio
Copy link

mohanio commented Oct 20, 2019

@cmyr , @nangtrongvuon added a fix for this here #481

@cmyr
Copy link
Member Author

cmyr commented Oct 20, 2019 •
edited

cool, thanks!

edit: will need to think about this a bit, but will give it a proper look monday or tuesday.

@mohanio mohanio linked a pull request Oct 21, 2019 that will close this issue
Open
7 tasks
mohanio pushed a commit to mohanio/xi-mac that referenced this issue Oct 21, 2019
Change default find highlight color
df6d765 
Issue:
xi-editor#470
Find highlight color defaults to red color instead it should use system's default find highlight color(NSColor.findHighlightColor)

Fix:
* Theme has new static variable representing default find highlight color
* Other find highlight colors are generated from the hue of default find highlight color
* Find highlight color specified by xi-editor on theme_changed event is ignored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#470 Change default find highlight color mohanio/xi-mac
3 participants
@cmyr @nangtrongvuon @mohanio