Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise row parser to delay sub-binary creation #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samsondav
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jul 12, 2017

Coverage Status

Coverage remained the same at 65.616% when pulling d4337e7 on samphilipd:row_parser_optimisations into 0e02865 on xerions:master.

@coveralls
Copy link

coveralls commented Jul 12, 2017

Coverage Status

Coverage increased (+0.1%) to 65.753% when pulling d4337e7 on samphilipd:row_parser_optimisations into 0e02865 on xerions:master.

@samsondav samsondav closed this Jul 14, 2017
@samsondav samsondav reopened this Jul 14, 2017
@coveralls
Copy link

coveralls commented Jul 14, 2017

Coverage Status

Coverage remained the same at 65.616% when pulling d4337e7 on samphilipd:row_parser_optimisations into 0e02865 on xerions:master.

@surik
Copy link
Member

surik commented Jul 17, 2017

Hi @samphilipd, can you explain your changes?

@samsondav
Copy link
Contributor Author

@surik Sort of. I don't know why this works, but with this change three "NOT OPTIMIZED" becomes "OPTIMIZED" in the output when @compile :bin_opt_info is set.

@surik
Copy link
Member

surik commented Jul 17, 2017

I'm not sure that it gives something expect some changes in compiler output with bin_opt_info option.

@fishcakez
Copy link
Contributor

fishcakez commented Oct 19, 2017

This change prevents a binary reference being created when decode_text_part is called in the tail of decode_text_rows but not other functions in this change. In the other cases it simply delays the reference being created to next call. It works for those cases as no pattern matching to left of the rest arg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants