[UI] Changed default Windows font & Allow loading custom font #2135
Conversation
Gliniak
commented
Feb 25, 2023
•
Gliniak
commented
- Changed font on Windows to tahoma
- Allowed loading Greek and Cyrillic glyphs
- Unified font size to 12. This causes default UI to look a bit bigger
- Set oversample to 2 to make font more readable (especially custom fonts)
Gliniak
force-pushed
the
fontLoader
branch
2 times, most recently
from
cd3180b
to
bef4e5d
Compare
|
Hello! |
|
Sure (at least on windows), do you know font that looks good and support these glyphs? |
|
SegoeUI, Arial, Times New Roman. |
|
Not sure what's a better idea there. |
|
What if bundle with emulator some free nice looking font as default, for example Koruri, it could be big - size is an issue? |
|
I will suggest similar solution that is used in canary. Priority of font loading:
If no font is loaded then load default font.
How Tahoma looks like (with font set to 16) |
|
Brilliant! Thank you very much!!! |
Gliniak
changed the title
src/xenia/ui/imgui_drawer.cc
Outdated
| PWSTR fonts_dir; | ||
| HRESULT result = SHGetKnownFolderPath(FOLDERID_Fonts, 0, NULL, &fonts_dir); | ||
| if (FAILED(result)) { | ||
| CoTaskMemFree(static_cast<void*>(fonts_dir)); |
There was a problem hiding this comment.
fonts_dir would likely (though I'm not entirely sure about this specific case, of course) only be initialized if the function has succeeded, this freeing may cause a crash.
There was a problem hiding this comment.
https://learn.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-shgetknownfolderpath
The calling process is responsible for freeing this resource once it is no longer needed by calling [CoTaskMemFree](https://learn.microsoft.com/en-us/windows/desktop/api/combaseapi/nf-combaseapi-cotaskmemfree), whether SHGetKnownFolderPath succeeds or not
src/xenia/ui/imgui_drawer.cc
Outdated
| font_path = std::wstring(fonts_dir); | ||
| CoTaskMemFree(static_cast<void*>(fonts_dir)); | ||
| #endif | ||
| font_path.append(font_name); |
There was a problem hiding this comment.
A blank line above this line would make the code visually more structured.
src/xenia/ui/imgui_drawer.cc
Outdated
| 0, | ||
| }; | ||
|
|
||
| const std::filesystem::path ImGuiDrawer::GetWindowsFont(std::string font_name) { |
There was a problem hiding this comment.
I think this might have been more platform-independent as other operating systems also have their own font storages, and possibly accepting the name (family, weight, italic, etc. possibly) of the font with the necessary lookups in the OS rather than directly the file name. The fallback behavior is also pretty non-obvious in this function. On Windows, it returns an empty path if it has failed to obtain the system fonts directory. However, on other platforms, it just silently tries to get the path from the working directory instead.
src/xenia/ui/imgui_drawer.cc
Outdated
| const std::filesystem::path font_path = GetWindowsFont("tahoma.ttf"); | ||
| if (!std::filesystem::exists(font_path)) { | ||
| XELOGW( | ||
| "Unable to find tahoma font in Windows fonts directory. Switching to " |
- Unified font size to 12. This causes default UI to look a bit bigger - Set oversample to 2 to make font more readable (especially custom fonts)
