Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved clang-format to tools directory #2102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

p01arst0rm
Copy link

@p01arst0rm p01arst0rm commented Dec 29, 2022

Moved the clang-format tool into the /tools directory.

@Triang3l
Copy link
Member

It's a third-party component, why (and also why #2098)? For the ease of managing licenses and updating, we don't put, for instance, the Vulkan headers in src/xenia/ui/vulkan.

@gibbed
Copy link
Member

gibbed commented Dec 29, 2022

I accepted #2098 because vswhere is a binary, I don't think we need to move clang-format.

@Devman219
Copy link

Thank you

@p01arst0rm
Copy link
Author

It's a third-party component, why (and also why #2098)? For the ease of managing licenses and updating, we don't put, for instance, the Vulkan headers in src/xenia/ui/vulkan.

using a single directory to contain all third party code is a legacy buildsystem design technique. placing tools in directories that align with their actual project use is easier;- it also allows you to ignore entire directories to exclude them from packages. newer project layouts place documentation in /doc tools in /tools data in /data and so on

There is also some code within third_party which is actually xenia project code, the third_party label appears to be entirely arbitrary .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants