fix the dependencies of old loader #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: subaoon <subaru.fukuda@gmail.com>
Signed-off-by: subaoon <subaru.fukuda@gmail.com>
Signed-off-by: subaoon <subaru.fukuda@gmail.com>
|
@tohojo, @netoptimizer |
tohojo
requested changes
May 16, 2024
| $ t exec -n test -- ./xdp_loader -d veth0 -F --progsec xdp_pass | ||
| $ t load -n test -- -F --progsec xdp_icmp_echo | ||
| $ t exec -n test -- ./xdp-loader load --prog-name xdp_pass_func veth0 xdp_prog_kern.o | ||
| $ t load -n test -- --prog-name xdp_icmp_echo_func xdp_prog_kern.o |
There was a problem hiding this comment.
There are three invocations of xdp_loader at the end of the README file as well. Let's include those while you're fixing things up :)
There was a problem hiding this comment.
Thank you for your feedback.
updated README.
Signed-off-by: subaoon <subaru.fukuda@gmail.com>
tohojo
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0ded568, made by @donaldh and already merged, changed COPY_LOADER from
xdp_loadertoxdp-loader, but there are still dependencies onxdp_loader.I fixed the following:
xdp-loaderinstead ofxdp_loaderin testenv.sh.xdp-loaderand must be pinned.related issues
#393