add optional package attribute to testsuite element #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, we need use junit-noframe.xsl to conver to html. That XSLT requires a package attribute on testsuite element. According to JUnit XML reporting file format: http://llg.cubic.org/docs/junit/. This attribute should be derived from name. Though it is optional, I'd suggest adding it to make JUnit report more compatible for more consumers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, we need use junit-noframe.xsl to conver to html. That XSLT requires a package attribute on testsuite element. According to JUnit XML reporting file format: http://llg.cubic.org/docs/junit/. This attribute should be derived from name in XCTest situation, I thik it should be same as name since Objective-C don't have Package concept. Though it is optional, I'd suggest adding it to make JUnit report more compatible for more consumers.