Fixed LayoutRoot implementation of IXmlSerializable.ReadXml to read the end element. #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2019 17:51
…he end element. Implementations of IXmlSerializable.ReadXml are required to read the entire element from beginning to end, including all of its contents. Prior to this change it would not read the end element from the reader. This would cause issues if the LayoutRoot was being serialized as part of a parent object's xml serialization as the XmlReader would be left on an unexpected element.
|
@prmartinuk I have included your change in my branch over her: ...and will release this to Nuget with the next version this weekend. But you can of course wait about 2 years until XCeed's version 3.9 is open sourced or pay money to get the change whenever its actually included :-) even that seems to be a matter of years or never if you look at the other PRs in this repository... |
|
Hi @prmartinuk , v3.6 was released for the community a few weeks ago and v3.7 is coming in the next few days. It won't take long for v3.9 (commercial and community) versions to be released. Stay tunes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations of IXmlSerializable.ReadXml are required to read the entire element from beginning to end, including all of its contents. Prior to this change it would not read the end element from the reader. This would cause issues if the LayoutRoot was being serialized as part of a parent object's xml serialization as the XmlReader would be left on an unexpected element.