New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PVR][guilib][Estuary] Guide window improvement #25142
Conversation
9e523c0
to
982dc2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from the C++ side.
Just a quick note to acknownlege the review request has been seen. I'll try and get to it beofre the weekend. |
Looking at the code I don't see any issues, however I've not had time to runtime test which I'd like to do for this PR before Approving. I'm away this weekend but I should have time on Monday if you're not in hurry @ksooo |
982dc2d
to
a51ef75
Compare
…nail are available, show both, like we already do in fullscreen OSD.
a51ef75
to
4bd3e88
Compare
jenkins build this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation: Currently, the Guide window can either display the channel logo or a thumbnail of the programme. If both graphics are available, thumbnail will be preferred. In the fullscreen live TV OSD however, we can show both graphics already:
This PR aligns the guide window content with the OSD contain by adding support for channel logo and programme thumbnail, similar to the OSD.
Before:
After:
In case only channel logo is available, guide window will look like before, channel logo on the left, text area spans to right border of screen.
For this, new GUI info labels were needed:
ListItem.ChannelLogo, VideoPlayer.ChannelLogo, MusicPlayer.ChannelLogo, completing the other channel related labels, (like ListItem.ChannelName and ListItem.ChannelNumberLabel). These labels contain the path of the channel logo of the selected or playing pvr channel.
Runtime-tested on macOS and Android, latest xbmc master.
@jjd-uk could you please have a look at the skin changes?
@phunkyfish please review the code changes.