Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script.videolinks] 1.0.1 #2598

Open
wants to merge 2 commits into
base: omega
Choose a base branch
from

Conversation

the-black-eagle
Copy link

Description

Although the python artist scraper now fetches video links from theaudiodb, this standalone version can fetch the links for just a single artist ( or all artists) without updating anything else. It's therefore possible using this addon to add links at theaudiodb and then update Kodi with them, without affecting anything else.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

fuzzard and others added 2 commits February 20, 2023 08:34
Co-authored-by: fuzzard <fuzzard@kodi.tv>
@basrieter
Copy link
Contributor

Could you please fix your conflicts (most likely by rebasing)?

@basrieter
Copy link
Contributor

Please rebase to resolve the conflicts.

romanvm
romanvm previously approved these changes May 4, 2024
@@ -0,0 +1,37 @@
# -*- coding: utf-8 -*-
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed in Py 3

@romanvm romanvm added the Approved Approved and is ready to merge label May 4, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be in your PR. Please exclude it.

@basrieter basrieter dismissed romanvm’s stale review May 4, 2024 15:45

targets.cfg should not be there.

@basrieter basrieter removed the Approved Approved and is ready to merge label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants