Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script.module.googleapi] 2.67.0 #2360

Open
wants to merge 1 commit into
base: matrix
Choose a base branch
from

Conversation

JavaWiz1
Copy link

@JavaWiz1 JavaWiz1 commented Dec 4, 2022

Description

Update to v2.x for Arlo plugin

Checklist:

  • [x ] My code follows the add-on rules and piracy stance of this project.
  • [x ] I have read the CONTRIBUTING document
  • [x ] Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@JavaWiz1
Copy link
Author

JavaWiz1 commented Dec 4, 2022

The invalid json

  • ERROR: Invalid json found. ./script.module.googleapi/lib/googleapiclient/discovery_cache/documents/admin.datatransferv1.json
  • ERROR: Invalid json found. ./script.module.googleapi/lib/googleapiclient/discovery_cache/documents/admin.directoryv1.json
  • ERROR: Invalid json found. ./script.module.googleapi/lib/googleapiclient/discovery_cache/documents/admin.reportsv1.json

are symbolic links and should not be flagged as errors as that's how they exist in the google repo.

Please advise...

@L2501
Copy link

L2501 commented Dec 7, 2022

Symlinks might not work on all platforms, you would need to make a copy.

@JavaWiz1
Copy link
Author

JavaWiz1 commented Dec 9, 2022

Symlinks might not work on all platforms, you would need to make a copy.

Done, copied.

@romanvm
Copy link
Collaborator

romanvm commented Feb 25, 2023

What is the source of this? PyPI doesn't have 2.67.0 version: https://pypi.org/project/google-api-python-client/#history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants