Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service.plexskipintro] 1.0.0 #2221

Open
wants to merge 5 commits into
base: matrix
Choose a base branch
from
Open

Conversation

Darkmadda
Copy link

Description

Checklist:

  • [x ] My code follows the add-on rules and piracy stance of this project.
  • [x ] I have read the CONTRIBUTING document
  • [x ] Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

Copy link
Contributor

@basrieter basrieter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please start with my initial comments. I (or someone else) will re-review it after the initial fixes.

@@ -0,0 +1,30 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't submit .github files in a PR.

@@ -0,0 +1,18 @@
### Description
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't submit github files in a PR.

@@ -0,0 +1,95 @@
### Introduction
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't submit github files in a PR.

<description lang="en">Prompt a Skip Intro dialog Netflix style using plex metadata. Skips intro for your favourite shows</description>
<summary lang="en">Skip TV Shows Intro</summary>
<platform>all</platform>
<forum>-</forum>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fill out all the information and add the SDPX for the license.

import time

def closeDialog():
global Dialog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are all these globals in this file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these globals are being used to pass around values between defs for various variables such as the times of the intro or the dialog to be displayed/hidden

@basrieter
Copy link
Contributor

Ping @Darkmadda

Requested as in review suggestion
Requested as in review suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants