Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.catchuptvandmore@matrix] 0.2.39+matrix.1 #4510

Open
wants to merge 1 commit into
base: matrix
Choose a base branch
from

Conversation

joaopa00
Copy link

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Once more, this PR is pretty huge. This was caused by the problem in youtube-dl script on which Catchuptvmore is based. Youtube-dl had to be merged before one can request a PR for Catchuptvandmore

Thanks for your understanding.

@basrieter
Copy link
Contributor

Thanks, I will go through the changes this weekend (I hope).

@joaopa00 joaopa00 force-pushed the matrix branch 2 times, most recently from be5dcb9 to 609579b Compare April 28, 2024 01:45
@basrieter
Copy link
Contributor

Sorry it is taking some time. Just came back from a week off and away. I am about halfway the PR now.

@joaopa00
Copy link
Author

Thanks for your feedback. is your review soon finished now?

Copy link
Contributor

@basrieter basrieter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the comments. The 4K lines file with 95% commented, looks odd? And the SSL thing needs to change.

Copy link
Contributor

@basrieter basrieter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants