Add pylint checks #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enen92
reviewed
Jun 29, 2018
kodi_addon_checker/pylint_checks.py
Outdated
|
|
||
| json_data = json.loads(out.getvalue()) | ||
| for issue in json_data: | ||
| table_format.append([short_path(issue['path']), issue['line'], issue['message']]) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
enen92
reviewed
Jun 29, 2018
kodi_addon_checker/pylint_checks.py
Outdated
| table_format.append([short_path(issue['path']), issue['line'], issue['message']]) | ||
|
|
||
| table = AsciiTable(table_format).table | ||
| report.add(Record(WARNING, table)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Rechi
reviewed
Jul 7, 2018
kodi_addon_checker/check_addon.py
Outdated
| @@ -42,6 +43,10 @@ def start(addon_path, branch_name, all_repo_addons, pr, config=None): | |||
|
|
|||
| check_dependencies.check_addon_dependencies(addon_report, repo_addons, parsed_xml, branch_name) | |||
|
|
|||
| pylint_checks.analyze(addon_report, addon_path) | |||
|
|
|||
| check_dependencies.check_addon_dependencies(addon_report, repo_addons, parsed_xml) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Rechi
reviewed
Jul 8, 2018
requirements.txt
Outdated
| @@ -1,3 +1,5 @@ | |||
| pillow | |||
| requests | |||
| radon | |||
| pylint | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Rechi
reviewed
Jul 8, 2018
kodi_addon_checker/pylint_checks.py
Outdated
| def analyze(report: Report, filename: str): | ||
| table_format = [["Line no", "Message", "message-id"]] | ||
|
|
||
| ARGS = ["-r", "n", "--score=yes", "--lint-all=y", "--rcfile=.pylintrc"] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Rechi
reviewed
Jul 9, 2018
kodi_addon_checker/.pylintrc
Outdated
| persistent=yes | ||
|
|
||
| # Specify a configuration file. | ||
| rcfile=/home/mzfr/dev/Addon-check/Misc/Demo/ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
mzfr
force-pushed
the
pylint
branch
3 times, most recently
from
073611c
to
4d2b7f7
Compare
Rechi
force-pushed
the
pylint
branch
2 times, most recently
from
41c5adf
to
04ce558
Compare
added 5 commits
May 13, 2023 10:42
Removed all C type error code from pylint checks and enabled F type error codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we will be able check our addons with pylint.
The output will look like:
Currently all the checks are enabled on line 17 in
.pylintrcbut we can then disable the ones we don't want.