Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option skip-dependency-checks #264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add option skip-dependency-checks #264

wants to merge 1 commit into from

Conversation

goggle
Copy link
Contributor

@goggle goggle commented Mar 25, 2023

Adds an option to ignore dependency checks.
The reason for this is outlined in #263.
Closes #263.

@razzeee
Copy link
Member

razzeee commented Mar 27, 2023

I still think we should go for modes and not for single settings, like outlined in #158 (comment)

@goggle
Copy link
Contributor Author

goggle commented Mar 28, 2023

Are the failing GitHub Action checks my fault? Have I forgotten to add something?

@razzeee
Copy link
Member

razzeee commented Mar 28, 2023

Seems like the tests expect skip_dependency_checks to be there now. Either the default is not working or it's not affecting the test suite (as it might only start below that layer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razzeee razzeee razzeee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to ignore dependency checks
2 participants
@goggle @razzeee