Handle IPv6 #4
Handle IPv6 #4
Conversation
|
Here's a screenshot displaying an ipv6 address |
|
The way IP6 is handled varies: sometimes the code branches at the top, and at other times on a per-statement basis using if-expressions. It also treats IP6 as a boolean where it is by nature more an enumeration and we could envision more cases (albeit not short term). It's difficult to do this in a systematic and nice way - so I think it's ok. |
benjamreis
force-pushed
the
adapt-for-ipv6
branch
2 times, most recently
from
77ff359
to
dd2b06d
Compare
|
Hey, is something missing for this PR to be merged? It's been approved a while ago. |
xapi-project/xsconsole#4 Signed-off-by: BenjiReis <benjamin.reis@vates.fr>
xapi-project/xsconsole#4 Signed-off-by: BenjiReis <benjamin.reis@vates.fr>
bernhardkaindl
dismissed
their stale review
The changes I requested have been addressed
There was a problem hiding this comment.
@benjamreis This PR has commit conflicts which have to be resolved, can you fix them?
benjamreis
force-pushed
the
adapt-for-ipv6
branch
from
f16f4d1
to
d998737
Compare
|
@bernhardkaindl rebased on latest master 👍 |
|
Ping @bernhardkaindl. Is there anything blocking the merge now? |
|
Hi @stormi, I asked about it, and the response was that we shall review it as part of our larger IPv6 project: Then when we'll have the requirements for handling IPv6 finished and the infrastructure for full IPv6 testing in all variants (single-stack, dual-stack and the required IPv6 address configuration variants) is available for testing. |
|
Thanks for asking. I'm disappointed by the answer, to be honest. It makes it sound like XenServer is the only user of xsconsole. XCP-ng 8.3 (development version) already supports IPv6. In fact, we have been adding support in many components, and uncovering and fixing issues for you, which will make your own IPv6 project easier. We've worked on it for several years, have users testing it, are currently adding tests in our CI, uncovering more issues in the process. Here, all we ask is that a rather simple PR is merged so that we don't have to maintain a separate branch of xsconsole (and rebase each time the master branch changes - and there might be a python 3 port on the way), for months if not years. The PR is simple, was reviewed, refined, and moreover should not impact XenServer in any way when IPv6 is not enabled in XAPI. We're already 2 years 1/4 after the initial commits. If any regression is found in your IPv4-based tests that our own tests haven't uncovered, we can fix it, and you can revert the PR while waiting for the fix. When you start working on IPv6 support, you can then have a new look at what has been done, and determine whether it's good enough - as it seemed when merging -, or needs to be improved. |
| retVal = pif['netmask'] | ||
| ipv6 = pif['primary_address_type'].lower() == 'ipv6' | ||
| try: | ||
| retVal = pif['IPv6'][0].split('/')[1] if ipv6 else pif['netmask'] |
There was a problem hiding this comment.
Maybe add in a comment an example for the expected format - to understand why this should work with IPv6?
benjamreis
force-pushed
the
adapt-for-ipv6
branch
3 times, most recently
from
db9de97
to
b2d465c
Compare
Display IPv6 PIF's fields when `primary_address_type` is `IPv6` Reconfigure management interface with appropriate method Support network reset in the IPv6 case Signed-off-by: BenjiReis <benjamin.reis@vates.fr>
benjamreis
force-pushed
the
adapt-for-ipv6
branch
from
b2d465c
to
b990b4e
Compare
Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
Display IPv6 PIF's fields when
primary_address_typeisIPv6Reconfigure management interface with appropriate method
Support network reset in the IPv6 case
Signed-off-by: BenjiReis benjamin.reis@vates.fr