upstream: non-breaking dependencies #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor: drop dependency on base-bytes Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Minor: ocaml 5.2 compatibility Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Minor: OCaml 5.2 compatibility Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Minor: adds support for more datatypes Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Minor: random bunch of additions, and fixes such as dune exec --watch Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
edwintorok
reviewed
May 10, 2024
| @@ -1,6 +1,6 @@ | |||
| opam-version: "2.0" | |||
| name: "ocamlformat-rpc-lib" | |||
| version: "0.26.1" | |||
| version: "0.26.2" | |||
There was a problem hiding this comment.
Do we need to update .ocamlformat anywhere?
There was a problem hiding this comment.
No, because it introduced a lot of friction at the time. There are not formatting changes between the versions
edwintorok
approved these changes
May 10, 2024
Minor: adds heterogeneous maps for the span context, use trace library Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
minor: ipv6 fixes for mirage packages Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
minor: fix in binary encoder Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Minor: OCaml 5.2 compatibility Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
minor: adds 4.14.2 and 5.2 versions Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
minor: OCaml 5.2 compatibility Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
minor: OCaml 5.2 compatibility Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
robhoes
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of them have small fixes, or add ocaml 5.2 compatibility. I want to keep changes to a minimum before using ocaml 4.14.2, I'll force the new interface for mirage-crypto on the next update