CP-48011: XAPI Support anti-affinity feature check #5631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BengangY
force-pushed
the
private/bengangy/CP-48011-review
branch
from
bf9facd
to
ae33ef1
Compare
BengangY
changed the title
BengangY
commented
May 16, 2024
lindig
approved these changes
May 16, 2024
ocaml/xapi/xapi_vm_group_helpers.ml
Outdated
| let host_uuid = Db.Host.get_uuid ~__context ~self:host in | ||
| let body = | ||
| String.concat "" | ||
| [ |
There was a problem hiding this comment.
It's probably not easy to add: but how rules are violated would be useful to know.
There was a problem hiding this comment.
The breaching for anti-affinity rule can be accessed in this PR: #5605
BengangY
force-pushed
the
private/bengangy/CP-48011-review
branch
from
ae33ef1
to
5b18928
Compare
|
The new commit looks fine in principle. But we need to get the other PR done first and then rebase this PR. |
BengangY
force-pushed
the
private/bengangy/CP-48011-review
branch
2 times, most recently
from
6545480
to
cf11976
Compare
minglumlu
reviewed
May 28, 2024
Check feature flag in these places: 1. VM start. 2. Host evacuation. When this PR is raised, the host evacuation PR is still in review. So this PR doesn't include the checking for host evacuation. It will be included in another new PR. 3. Create VM group. 4. VM.set_groups. Adding VMs to a group and removing VMs from a group are all forbidden. If customers need to remove VMs from a group, just destroy the group. 5. Send VM anti-affinity alerts. Also, based on our discussion, the name of feature is changed from `VM_anti_affinity` to `VM_group`. Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
BengangY
force-pushed
the
private/bengangy/CP-48011-review
branch
from
cf11976
to
606423e
Compare
minglumlu
approved these changes
May 28, 2024
minglumlu
merged commit 6529c0b
into
xapi-project:feature/vm-anti-affinity
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check feature flag in these places:
still in review. So this PR doesn't include the checking for host
evacuation. It will be included in another new PR.
are all forbidden. If customers need to remove VMs from a group,
just destroy the group.
Also, based on our discussion, the name of feature is changed from
VM_anti_affinitytoVM_group.