CP-47356: Support backwards capability for Go SDK

[duobei]

No description provided.

[xueqingz]

From generated source files, for methods under session.go, it's not correct. eg.

func (class *Session) LoginWithPassword3(pwd string, version string) (retval SessionRef, err error) {
	method := "session.login_with_password"
	unameArg, err := serializeString(fmt.Sprintf("%s(%s)", method, "uname"), uname)
	if err != nil {
		return
	}
	pwdArg, err := serializeString(fmt.Sprintf("%s(%s)", method, "pwd"), pwd)
	if err != nil {
		return
	}
	versionArg, err := serializeString(fmt.Sprintf("%s(%s)", method, "version"), version)
	if err != nil {
		return
	}
	result, err := class.client.sendCall(method, unameArg, pwdArg, versionArg)
	if err != nil {
		return
	}
	retval, err = deserializeSessionRef(method+" -> ", result)
	if err != nil {
		return
	}
	class.ref = retval
	err = setSessionDetails(class)
	return
}

obviously missing parameter "uname" in functions. please check the generated JSON data.
same for other methods which doesn't have value "session_id" in function's parameters.

[duobei]

From generated source files, for methods under session.go, it's not correct. eg.

func (class *Session) LoginWithPassword3(pwd string, version string) (retval SessionRef, err error) {
	method := "session.login_with_password"
	unameArg, err := serializeString(fmt.Sprintf("%s(%s)", method, "uname"), uname)
	if err != nil {
		return
	}
	pwdArg, err := serializeString(fmt.Sprintf("%s(%s)", method, "pwd"), pwd)
	if err != nil {
		return
	}
	versionArg, err := serializeString(fmt.Sprintf("%s(%s)", method, "version"), version)
	if err != nil {
		return
	}
	result, err := class.client.sendCall(method, unameArg, pwdArg, versionArg)
	if err != nil {
		return
	}
	retval, err = deserializeSessionRef(method+" -> ", result)
	if err != nil {
		return
	}
	class.ref = retval
	err = setSessionDetails(class)
	return
}

obviously missing parameter "uname" in functions. please check the generated JSON data. same for other methods which doesn't have value "session_id" in function's parameters.

Yeah, there is a bug here. I'll fix soon.

--
Fixed

[xueqingz]

When checking Golong lint , got 3 errors, could you please check why the method version for "VM.restart_device_models" is null?

root@3eea0d3e0e5d:/app/go/goSDK# golangci-lint run --config=/app/.golangci.yml
WARN The linter 'execinquery' is deprecated (since v1.58.0) due to: The repository of the linter has been archived by the owner.  
WARN The linter 'gomnd' is deprecated (since v1.58.0) due to: The linter has been renamed. Replaced by mnd. 
vm.go:264: File is not `gci`-ed with --skip-generated -s standard -s default (gci)
//
vm.go:287: File is not `gci`-ed with --skip-generated -s standard -s default (gci)
//
vm.go:314: File is not `gci`-ed with --skip-generated -s standard -s default (gci)
//
3 issues:
* gci: 3

[duobei]

root@3eea0d3e0e5d:/app/go/goSDK# golangci-lint run --config=/app/.golangci.yml
WARN The linter 'execinquery' is deprecated (since v1.58.0) due to: The repository of the linter has been archived by the owner.  
WARN The linter 'gomnd' is deprecated (since v1.58.0) due to: The linter has been renamed. Replaced by mnd. 
vm.go:264: File is not `gci`-ed with --skip-generated -s standard -s default (gci)
//
vm.go:287: File is not `gci`-ed with --skip-generated -s standard -s default (gci)
//
vm.go:314: File is not `gci`-ed with --skip-generated -s standard -s default (gci)

There is a bug hidden here. I'll fix it soon.

[xueqingz]

Golang lint checking pass.

root@3eea0d3e0e5d:/app/go/goSDK# golangci-lint run --config=/app/.golangci.yml
WARN The linter 'gomnd' is deprecated (since v1.58.0) due to: The linter has been renamed. Replaced by mnd. 
WARN The linter 'execinquery' is deprecated (since v1.58.0) due to: The repository of the linter has been archived by the owner.  
0 issues.

test with xs-samples go project, no special error found.

[minglumlu]

Hi @duobei
Thanks. I only added a few more minor comments for the naming convention.

[github-actions]

pytype_reporter extracted 50 problem reports from pytype output

.

You can check the results of the job here