CP-48855: fix go lint var-name warnings #5606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duobei
force-pushed
the
private/fezhan/CP-48855
branch
from
6fad09d
to
b09da9e
Compare
contificate
reviewed
Apr 30, 2024
contificate
reviewed
Apr 30, 2024
lindig
approved these changes
May 1, 2024
duobei
force-pushed
the
private/fezhan/CP-48855
branch
from
b09da9e
to
41f8f36
Compare
minglumlu
reviewed
May 6, 2024
duobei
changed the title
duobei
changed the title
Signed-off-by: xueqingz <xueqing.zhang@citrix.com> Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
changed templates: APIVersions.mustache,APIErrors.mustache, Record.mustache Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
Signed-off-by: xueqingz <xueqing.zhang@citrix.com> Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
duobei
changed the title
Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
duobei
force-pushed
the
private/fezhan/CP-48855
branch
from
41f8f36
to
fdf5f25
Compare
minglumlu
reviewed
May 6, 2024
minglumlu
approved these changes
May 6, 2024
|
Shall we also add unit test for "APIVersion.mustache" and "Option.mustache"? I check the generated source files, Go templates looks good to me. |
Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
Signed-off-by: Luca Zhang <feiya.zhang@cloud.com>
duobei
force-pushed
the
private/fezhan/CP-48855
branch
from
fdf5f25
to
e6c5e65
Compare
pytype_reporter extracted 50 problem reports from pytype output. You can check the results of the job here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix go lint var-name warnings
Others