[OIL] Use mustache templates to build Java SDK + Add Java SDK build step to actions #5595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-delbusso
force-pushed
the
oil/java
branch
from
5e628b5
to
0bd9973
Compare
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Also adds a better definition of the compare function for module Ty. The previous one was leaving duplicates in the set by relying on the underlying `Set.compare`. Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Also update wording in `parseResult` Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, I couldn't come up with an easy way to keep the same order of types in
Types.java. The issue here is that they were added as they were found, so there was no specified order.A good way to check would probably be to compare class structures instead. I'm happy to assist if possible.
The SDK sources are present in the PR's artifacts so you don't have to build them yourself.
This PR also adds the JAR to the release files.
Note that I did keep the existing side-effect operations of updating
enums,types, etc.. I found that they weren't that much of an hassle to keep but feel free to weigh in.For result of a release with the changes here see https://github.com/danilo-delbusso/xen-api/releases/tag/v60.1.3