CP-38343: xenopsd: GC and memory RRD stats #5522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should target the perf feature branch, but that one is out-of-date and needs #5523 first |
Based on xapi_stats.ml, but heavily refactored. Signed-off-by: Edwin Török <edvin.torok@citrix.com> (cherry picked from commit 40d3aa7923c7a5c7654d9e83508e52b3b7c3840a) (cherry picked from commit b30f2310e6087ef59c486410f079175bf36aa705)
edwintorok
force-pushed
the
private/edvint/stats3
branch
from
5559e8f
to
b203731
Compare
Vincent-lau
reviewed
May 2, 2024
|
|
||
| let mutex_execute = Xapi_stdext_threads.Threadext.Mutex.execute | ||
|
|
||
| let reporter_async ~shared_page_count ~dss_f = |
There was a problem hiding this comment.
there is already a start_async in rrdd_plugin.ml, why not use that one?
| observe_stats stats ; | ||
| stats |> List.rev_map (fun x -> (Rrd.Host, x)) | ||
|
|
||
| let generate_stats () = |
There was a problem hiding this comment.
emm, two functions with the same name, one shadowing another? maybe define an inner function?
lindig
approved these changes
May 3, 2024
| match Astring.String.cut ~sep:" " s with None -> s | Some (v, _) -> v | ||
|
|
||
| (** [parse_value s] parses values of the form ' N kB' or ' N'. *) | ||
| let parse_value s = s |> Astring.String.trim |> drop_unit |> Int64.of_string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on xapi_stats.ml, but heavily refactored.
Signed-off-by: Edwin Török edvin.torok@citrix.com
This is xapi-project/xenopsd#772, but I squashed and rebased the 2 commits on top of latest master, and ran
ocamlformat, and fixed some dune warnings.Original commits in xenopsd repo:
(cherry picked from commit 40d3aa7923c7a5c7654d9e83508e52b3b7c3840a)
(cherry picked from commit b30f2310e6087ef59c486410f079175bf36aa705)
So far I've only compile tested this change, hence a draft.