Fix varstore-sb-state exit code #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 'user' mode, varstore-sb-state exit code is the returned value of the function setup_keys() which returns true on success and false otherwise. The exit code is then 1 on success and 0 on failure, the opposite of the 'setup' mode. This patch fixes the exit code, returning 0 when setup_keys() succeeds and 1 otherwise. Signed-off-by: Thierry Escande <thierry.escande@vates.tech>
rosslagerwall
approved these changes
Oct 25, 2023
|
Regarding return codes, this will change the return code from 1 to 0 also in this case: xcp-ng@74a5856. Is it the expected behaviour? I thought it would return false, due to the fact that switching to user mode failed. |
|
Thanks for the approval but I cannot add other reviewers myself. Would you mind please ? Regards, |
|
Another approval is necessary, but we can't add reviewers ourselves. |
xennifer
approved these changes
Mar 21, 2024
freddy77
reviewed
May 7, 2024
| @@ -112,7 +112,7 @@ int main(int argc, char **argv) | |||
| do_rm(&gEfiImageSecurityDatabaseGuid, "dbx"); | |||
|
|
|||
| if (!strcmp(argv[optind + 1], "user")) | |||
| return setup_keys(); | |||
| return (setup_keys() ? 0 : 1); | |||
There was a problem hiding this comment.
return !setup_keys(); ? Or return (setup_keys() ? EXIT_SUCCESS : EXIT_FAILURE); to be more explicit ?
freddy77
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 'user' mode, varstore-sb-state exit code is the returned value of the function setup_keys() which returns true on success and false otherwise. The exit code is then 1 on success and 0 on failure, the opposite of the 'setup' mode.
This patch fixes the exit code, returning 0 when setup_keys() succeeds and 1 otherwise.