CA-384942: path to the VM CD drive has been resolved to real device #684
+39
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinLCtx
previously approved these changes
May 2, 2024
rdn32
previously approved these changes
May 2, 2024
TimSmithCtx
previously approved these changes
May 2, 2024
andyhhp
reviewed
May 2, 2024
The error handling for empty CD drive assumes a path containing '/dev/xapi/cd/' but the path has been resolved to the actual device before the open operation is attempted. Check for paths of the form '^/dev/sr' as well so that the correct error message is emitted. Signed-off-by: Mark Syms <mark.syms@citrix.com>
MarkSymsCtx
dismissed stale reviews from TimSmithCtx, rdn32, and KevinLCtx
via
534019f
KevinLCtx
approved these changes
May 7, 2024
andyhhp
approved these changes
May 7, 2024
TimSmithCtx
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error handling for empty CD drive assumes a path containing '/dev/xapi/cd/' but the path has been resolved to the actual device before the open operation is attempted. Check for paths of the form '^/dev/sr' as well so that the correct error message is emitted.