CA-390490: remove override of blktap request timeout #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this code was orginally added there was no default value for the nfs_timeout and so the timeout would only have been used if 1. The SR type was NFS 2. The SR had a overriden setting for nfs-timeout in the other-config Since that time the calculation of the NFS client timeout has been changed considerably and is set with a balance between timeo and retrans values. In particular the get_nfs_timeout method will now always return a non-zero value. This results in the SM always applying a request timeout to blktap of 50 seconds (unless the timeo value has been set in the SR device config), which is considerably lower than the default request timeout in blktap itself which is 120 seconds. NFS protocol timeouts are also no longer considered to be retryable errors within blktap so tying the timeout value to the NFS timeout, even if it were correctly calculated taking into account the retrans value, is effectively comparing two unrelated things. Signed-off-by: Mark Syms <mark.syms@citrix.com>
rdn32
approved these changes
Mar 26, 2024
KevinLCtx
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this code was orginally added there was no default value for the nfs_timeout and so the timeout would only have been used if
Since that time the calculation of the NFS client timeout has been changed considerably and is set with a balance between timeo and retrans values. In particular the get_nfs_timeout method will now always return a non-zero value. This results in the SM always applying a request timeout to blktap of 50 seconds (unless the timeo value has been set in the SR device config), which is considerably lower than the default request timeout in blktap itself which is 120 seconds.
NFS protocol timeouts are also no longer considered to be retryable errors within blktap so tying the timeout value to the NFS timeout, even if it were correctly calculated taking into account the retrans value, is effectively comparing two unrelated things.