vhd-meta.py #206
Open
vhd-meta.py #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script is useful for getting problematic VHDs off of a customer site without copying the entire VHD chain (which could be many GBs) or taking customer's sensitive data: the script copies only the metadata and recreates the VHD chain locally by adding zeros in place of data. Signed-off-by: Andrei Lifchits <andrei.lifchits@citrix.com> Signed-off-by: Germano Percossi <germano.percossi@citrix.com>
VHD BAT size on LVM is kept at its maximum on purpose, to allow future resizes without moving data around. The modification takes this into account Signed-off-by: Germano Percossi <germano.percossi@citrix.com> Reviewed-by: Vineeth Thampi Raveendran <vineeth.thampi@citrix.com>
A better description to be done.. Signed-off-by: Keith Petley <keith.petley@citrix.com> Signed-off-by: Germano Percossi <germano.percossi@citrix.com>
|
N.B: These pacthes won't be shipped in the RPM but we need a place to store them to have |
|
I guess it's just an "import", so I don't think we need any review at this point, Let's merge it! |
|
It is not an import. |
|
Just a note for improvement... The script appears to assume that each VDI has the same BAT size. Rackspace had to modify it to extract the metadata. |
|
In out case the BAT is always the same. If they want to send the patch over, we can include it here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we moved to github we dropped many utilities just because they were
not packaged in the RPM.
vhd-meta.py is one of those utilities.
The commits should be kept (IMHO) separated for historical reasons.
The first one is the original one from Andrei they we dropped.
The second one is my improved version to work with LVHD SRs (the previous one
was meant only for file based SRs). It was already reviewed and ready to be committed but
after we moved, because the original was not there the patch was dropped.
The third one is an improved version from Keith to cope with nasty situations were the footers
were corrupted. I did not spend time reviewind the patch in full so there is room for improving
the commit message.
These 3 patches are the state of the art of this script. There many versions scattered throughout
tickets from customers. An old version has been discarded because it was supersed by the first
commit from Andrei (it was a first attempt from Andrei to support a customer but then he refined
the patch).
Another version is not included because it was a hybrid: it had the second commit on top of a very
old version (see above).
So, these 3 patches together are exhaustive.