Use BroadcastChannel first in default strategy #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xanf please review! 😀 |
|
Will do tomorrow :) having birthday today, lol
пт, 16 июл. 2021 г., 19:46 Bradley Smith ***@***.***>:
… @xanf <https://github.com/xanf> please review! 😀
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRCJJYSS7JKCOGVZAYZXTTYBO6TANCNFSM5AP5BICQ>
.
|
|
Happy birthday!! 🍰 🎉 |
|
@Brad-- done, I will release it with npm tomorrow Thank you for your effort! |
|
🚀 |
|
@xanf seems like you forgot to merge this pr :D |
Dubzer
reviewed
Aug 16, 2021
CHANGELOG.md
Outdated
| @@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](http://keepachangelog.com/) | |||
| and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## [1.0.3 - 2020-07-16] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue 33
In the default strategy, use
BroadcastChannelfirst and fallback tolocalStorage.Also fixes
karma.confHeadless Chrome usage.