Refactor Android implementation #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When one wants to connect multiple BLE devices, the singleton approach doesn't work well. In addition, the adapter class member inside GattCallback is not being used, it is deleted as well. The access modifier of _gatt and _gattcallback inside Device is changed from protected to internal. Such that, the Adapter instance can update those fields upon connection attempt.
* Eliminte the need to create new device instance * Wire up RSSI to the device * Get DeviceState from the profileState given by GattCallback
we can remove them when the method finishes its work. Prior to the change, upon re-entry of ServiceList, the services entry are added more once because we did not remove previous added delegate.
… in interest. * Robustify removing delegates upon device disconnection
* During attempt to connect, if an device already has a Gatt instance, tear it down before trying to connect. * During attempt to disconnect, tear down the gatt instance to free all the android resources
…evice instance instead. * This is in preparation to allow read/write of characteristic to check if a device is disconnected before attempting those read/write actions.
* Minimize the number of new Device instance that is constructed * Delay Service discovered event registation until Discover service is called * Remove DiscoveredService handler once we receive the callback from OnDiscoveredService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 4518d95
Author: Steven Moy github@stevenmoy.com
Date: Fri May 15 14:37:10 2015 -0700
commit babab5f
Author: Steven Moy github@stevenmoy.com
Date: Fri May 15 14:02:51 2015 -0700
commit c538bb5
Author: Steven Moy github@stevenmoy.com
Date: Fri May 15 14:01:20 2015 -0700
commit 8ccc702
Author: Steven Moy github@stevenmoy.com
Date: Fri May 15 11:09:09 2015 -0700
commit d34e05c
Author: Steven Moy github@stevenmoy.com
Date: Fri May 15 08:31:41 2015 -0700
commit 4f3f153
Author: Steven Moy github@stevenmoy.com
Date: Fri May 15 07:48:46 2015 -0700