Fix phantom delegate trying to use its referenced gatt instance #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to the change, when one disconnect a connected device in Android, Device instance inserts a delegate to GattCallback instance to cache discovered Services. However, when one disconnects such device, the delegate is not removed. So upon next device connection, that delegate will attempt to reference a disposed Gatt instance and cause a crash. To reproduce this bug, you can try the following sequence: 1) Scan for Devices 2) Connect to Device A 3) Discovers Service of Device A 4) Dsiconnect Device A 5) Connect to Device A again 6) Discovers Service of Device A 7) Crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the change, when one disconnect a connected device in Android,
Device instance inserts a delegate to GattCallback instance to cache
discovered Services. However, when one disconnects such device, the
delegate is not removed. So upon next device connection, that delegate
will attempt to reference a disposed Gatt instance and cause a crash.
To reproduce this bug, you can try the following sequence: