Ensure the same item only appears once on the list #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to the change, the same item can be repeated added to the list. We use a map to ensure the same item (based on ID property) appear only once.
|
It turns out the behavior varies quite wildly between HTC One (M7) with Android 5.0.2 and Nexus 7 (2013) with Android 5.1.1. With the HTC M7, discovery can report the same item (with same guid) multiples time during the 10sec scan. Where as the Nexus 7 only reports same device during the 10sec interval. :/ |
|
Same problem happens with a Nexus 5 by default (Android 5.0 and Android 5.1). It will keep adding items to the list that have already been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the change, the same item can be repeated added to the list.
We use a map to ensure the same item (based on ID property) appear only once.