Blue radios compatibility #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is a sample of how I decoupled the Bluetooth LE from a radio vendor implementation. I created a new sample LEStream called BluetoothLEStream that takes a characteristic Id set interface in the constructor list. It can then be used for various radios.
I have included id sets for BlueRadio and the existing ReadBearLab set from the original LEStream.
Unfortunately, because of my present setup this has only been tested against our dev BlueRadio module with Xamarin IOS64. I do not have a RedBearLab unit to test with. Because of the nature of the changes the rest should work but I wanted to give a heads up.
You could make the constructor default value of null for the characteristic set. In this way, if the user does not supply a set, the constructor could use the the ReadBearLab by default.
Please feel free to use, cannibalise or discard as you see fit. I put in a couple of bug fixes in earlier commits on the branch
Michael Roop