Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the indentation of the sequence tab #4408 #4549

Conversation

derwin12
Copy link
Collaborator

@derwin12 derwin12 commented May 7, 2024

#4408 Attempt to clean up the display and properly indent the groups, models, strands and nodes.
image

@AzGilrock
Copy link
Collaborator

I can't really tell what's different. And for instance is the "Single Line" model part of the "Group with One Item"? Maybe the name threw me cause its looks like a lot more than one item. The Single Line is indented making it look like its under that group but the group doesn't have the minus box so I'm confused.

@AzGilrock
Copy link
Collaborator

I've always thought the layer number looked weird when expanded since the first line is a total and my eyes always think it should look like 1, 2, 3

@derwin12
Copy link
Collaborator Author

derwin12 commented May 7, 2024

I've always thought the layer number looked weird when expanded since the first line is a total and my eyes always think it should look like 1, 2, 3

Agreed but the first line is [3] total layers .. perhaps flip that to [1] when expanded? would that change confuse people??

@derwin12
Copy link
Collaborator Author

derwin12 commented May 7, 2024

I can't really tell what's different. And for instance is the "Single Line" model part of the "Group with One Item"? Maybe the name threw me cause its looks like a lot more than one item. The Single Line is indented making it look like its under that group but the group doesn't have the minus box so I'm confused.

[-] is only to collapse layers.. BUT yes this is a bug .. going to fix that up
The first single line should be indented from the group but not the models sspinner and the model itself single line.
Expanded..
image
Collapsed..
image

@AzGilrock
Copy link
Collaborator

Hmm....so not sure why we don't use the +/- to expand/collapse groups.
Not sure sure about the layer numbering. We should number from the bottom up and say its the render order. :)

@cybercop23
Copy link
Collaborator

Hmm....so not sure why we don't use the +/- to expand/collapse groups. Not sure sure about the layer numbering. We should number from the bottom up and say its the render order. :)

Ohhhh.. I like that.... it will be the truth.... and the 3 on the group/model can stay as it... NICE

@deplanche
Copy link
Contributor

But Layer Blending is based on the current layer being Layer 1 and the layer below that being Layer 2. If they are numbered bottom to top, won't that confuse people even more?

@derwin12
Copy link
Collaborator Author

derwin12 commented May 7, 2024

Thoughts on this?
The numbering ... which way .. this may be something we just don't touch? - as it is built in for canvas mode and such..
Do I bother coding the Empty group to not show the [+] - like who creates empty groups besides me during testing..
What if the closed [3] changes to [1] then [2] then [3] when expanded??
image

@AzGilrock
Copy link
Collaborator

Nobody that would get confused blends layers. I'm not even sure what we're talking about layers blend from the bottom to the top inside the model/group layers.

@AzGilrock
Copy link
Collaborator

Blend is probably a bad work it doesn't really specify an order. All I can say is think of it like cans of paint. Bottom layer is the first can of spray paint. Next layer up is the second can of spray paint. I don't think the number showing on the left side has anything to do with how layers are handled internally.

@derwin12 derwin12 marked this pull request as draft May 7, 2024 20:59
@derwin12
Copy link
Collaborator Author

derwin12 commented May 7, 2024

Here is a new look .. shows 1.2.3 when expanded
image

@cybercop23
Copy link
Collaborator

I do really like the idea of showing them in the way they render... from the buttom up. Layer Belnding is done at the effect level, so it should not interfeer with how we display and manage the view itself.

@derwin12
Copy link
Collaborator Author

derwin12 commented May 9, 2024

Here is another rendition .. Not perfect - groups in groups are not (easily) determined for indenting. Better than before.
Notice I moved the group open and close indicator over to the right. The left side is/was required to open/close the layers.
You still just double click on it to open, but the triangle gives some clues as to what state you are in.
image

Subtle differences from current .10 release..
image

@derwin12 derwin12 closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants