Updated for stability #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ilystsov
suggested changes
Oct 31, 2023
| self._remove_comment(item) | ||
| if not self._trial_run: | ||
| item.delete() | ||
| while 1: |
There was a problem hiding this comment.
Suggested change
| while 1: | |
| MAX_RETRIES_COUNT = 5 | |
| for retries_count in range(MAX_RETRIES_COUNT): |
There was a problem hiding this comment.
Considering how long the script takes to run, limiting max retries is not ideal. Add an option to run indefinitely if you're really trying to change it. I understand the distaste for while 1 but the real experience is that it will not run to completion if you have a lot of posts because of the rate limiting.
| self._logger.debug("Encountered a problem with the API, probably ratelimiting thanks to bad admins") | ||
| self._logger.error(f"Exception: {e}") | ||
| self._logger.info(f"Waiting {self._batch_cooldown} seconds") | ||
| time.sleep(self._batch_cooldown) |
There was a problem hiding this comment.
Suggested change
| time.sleep(self._batch_cooldown) | |
| time.sleep(self._batch_cooldown) | |
| else: | |
| self.__logger.error( | |
| "Max retry attempts reached. Unable to complete the operation" | |
| ) |
ilystsov
suggested changes
Oct 31, 2023
ilystsov
suggested changes
Oct 31, 2023
Co-authored-by: ilystsov <127615303+ilystsov@users.noreply.github.com>
Co-authored-by: ilystsov <127615303+ilystsov@users.noreply.github.com>
Co-authored-by: ilystsov <127615303+ilystsov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: it would stop after a few hundred actions because API limits
Now: it will continue to run after an API limit exception, but wait 10 seconds before continuing.
I also updated the "requirements.txt" to work for my system (I'm using OSX, but it should run on linux distributions and WSL)