Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made compatible with 'Arrow' 0.14.5 #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

this-user
Copy link

The latest version of the Arrow library removed the deprecated functionality to use replace() with plural parameters. Calls like that should instead use shift(), which this patch does in order to restore functionality of the Shreddit script.

@iamdadmin
Copy link

Verified from #141 having implemented manually.

Copy link

@michael-patzer michael-patzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified fix. 👍

@colemickens
Copy link

This works, though I did have to install appdirs manually as well.

git clone https://github.com/x89/Shreddit
echo apply patch by hand
pip install .
pip install appdirs # required or else error
shreddit -u username .... # works

@jkldgoefgkljefogeg
Copy link

why is this still merged? No active user has write access to the repo any more?

@ellygaytor
Copy link

ellygaytor commented Jun 1, 2020

I made a fork with the fix; ellygaytor/Shreddit

I now have a replacement written from scratch: ellygaytor/trasheddit

@adadkins
Copy link

Can we merge these in?

@mikeriedel
Copy link

Can we merge these in?

It seems like all the contributors have gone inactive. Your message inspired me to message the creator on linkedin. I think everyone ends up at this specific repository because of search engines so I'd love to see this version get updated instead of everyone forking and duplicating effort.

Copy link

@manueltarouca manueltarouca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants