Add Config Split and Updates Log #348

ragnarkurmwunder · 2023-03-21T15:20:08Z

There is no ticket.
This PR is inspired by the need to integrate the Updates Log, and remove Warden.

Changes proposed in this PR:

Composer:
- Add: Updates Log
- Add: Config Split
Settings:
- Add: Updates Log
- Remove: Warden

How to test:

See if the Config Split is under contrib modules
See if the Updates Log is under contrib modules

$ ls -lad /app/web/modules/contrib/{config_split,updates_log}
drwxr-xr-x 1 www-data www-data 4096 Sep  3  2022 /app/web/modules/contrib/config_split
drwxr-xr-x 1 www-data www-data 4096 Mar 16 14:13 /app/web/modules/contrib/updates_log

Link to feature environment:
https://feature-updates-log--and--config-sp769.drupal-project.dev.wdr.io

misterjoonas · 2023-03-22T07:32:34Z

There could be some instructions in README in which environments the updates_log module should be enabled. Basically main and production, but not in feature branches. I hope they are separated by env variables in Silta?
Also Monolog needs to be enabled.

hkirsman · 2023-10-04T10:29:02Z

composer.json

        "drupal/core-composer-scaffold": "^10.0",
        "drupal/core-recommended": "^10.0",
        "drupal/monolog": "^3.0@beta",
        "drupal/simplei": "^2.0@beta",
        "drush/drush": "^11.4",
        "vlucas/phpdotenv": "^5.4",
        "webflo/drupal-finder": "^1.2",
-        "wunderio/drupal-ping": "^2.4"
+        "wunderio/drupal-ping": "^2.4",


I think we can also remove Warden because it's new projects that start using it? @tormi

hkirsman · 2023-10-04T10:33:08Z

composer.json

        "drupal/core-composer-scaffold": "^10.0",
        "drupal/core-recommended": "^10.0",
        "drupal/monolog": "^3.0@beta",
        "drupal/simplei": "^2.0@beta",
        "drush/drush": "^11.4",
        "vlucas/phpdotenv": "^5.4",
        "webflo/drupal-finder": "^1.2",
-        "wunderio/drupal-ping": "^2.4"
+        "wunderio/drupal-ping": "^2.4",
+        "wunderio/updates_log": "^2"


I noticed there's this profile web/profiles/custom/basic/basic.info.yml Is it supposed to be used during fresh Drupal projects? Should we enable the updates_log there? It had one bug that it could not find CKEditor atm.

@tormi

This has been on hold for a while. My position is that we should remove the basic profile and switch to minimal with config in config/sync folder. Then we can export config changes more easily. Also, we can implement config_split in a way it's been done in our projects.

hkirsman · 2023-10-04T10:35:29Z

web/sites/default/settings.php

@@ -42,17 +42,28 @@
  'bower_components',
 ];

+// $settings['updates_log_site'] = 'my-project-name';


Shouldn't there also be section in readme for getting this up and running?

@tormi @ragnarkurmwunder

@ragnarkurmwunder, I propose we leave updates_log_site and updates_log_env out from this template as it's targeting projects in Silta and the updates_log features are documented in it's repository.

tormi

Good stuff, but this needs some work.

tormi · 2023-12-27T22:50:29Z

composer.json

@@ -19,14 +19,16 @@
        "composer/installers": "^2.1",
        "cweagans/composer-patches": "^1.7",
        "drupal/admin_toolbar": "^3.3",
+        "drupal/config_split": "^2.0@RC",


This can be replaced now with 2.0, https://www.drupal.org/project/config_split/releases/2.0.0

We're introducing config_split component here, but without any settings & configs. I think we should at least add relevant settings in settings.php and related documentation.

tormi · 2023-12-27T22:53:20Z

composer.json

        "drupal/core-composer-scaffold": "^10.0",
        "drupal/core-recommended": "^10.0",
        "drupal/monolog": "^3.0@beta",
        "drupal/simplei": "^2.0@beta",
        "drush/drush": "^11.4",
        "vlucas/phpdotenv": "^5.4",
        "webflo/drupal-finder": "^1.2",
-        "wunderio/drupal-ping": "^2.4"
+        "wunderio/drupal-ping": "^2.4",


tormi · 2023-12-27T22:55:36Z

composer.json

        "drupal/core-composer-scaffold": "^10.0",
        "drupal/core-recommended": "^10.0",
        "drupal/monolog": "^3.0@beta",
        "drupal/simplei": "^2.0@beta",
        "drush/drush": "^11.4",
        "vlucas/phpdotenv": "^5.4",
        "webflo/drupal-finder": "^1.2",
-        "wunderio/drupal-ping": "^2.4"
+        "wunderio/drupal-ping": "^2.4",
+        "wunderio/updates_log": "^2"


Let's continue using MAJOR.MINOR syntax because it's also default in drupal.org release notes (f.ex composer require 'drupal/config_split:^2.0' in https://www.drupal.org/project/config_split/releases/2.0.0.

I noticed there's this profile web/profiles/custom/basic/basic.info.yml Is it supposed to be used during fresh Drupal projects? Should we enable the updates_log there? It had one bug that it could not find CKEditor atm.

Very good question, @hkirsman! I think we could even remove this custombasic install profile since we don't use install profiles in our projects. And the Drupal Recipes Initiative sums up the reasons nicely:

Historically this functionality has been served by install profiles and distributions, but both of those iterations of the problem have some flaws:

They are difficult to keep updated
They cannot be added after starting your project
They can't be removed easily
They can't be mixed and matched with other sets of functionality.

We're using recipes in our https://github.com/wunderio/next-drupal-starterkit template and it seems to be working well. Perhaps we should introduce it here as well?

tormi · 2023-12-27T23:08:55Z

web/sites/default/settings.php

@@ -42,17 +42,28 @@
  'bower_components',
 ];

+// $settings['updates_log_site'] = 'my-project-name';


@ragnarkurmwunder, I propose we leave updates_log_site and updates_log_env out from this template as it's targeting projects in Silta and the updates_log features are documented in it's repository.

tormi · 2023-12-27T23:12:31Z

web/sites/default/settings.php

+// $settings['updates_log_env'] = getenv('ENVIRONMENT_NAME');
+// In Silta it is set by default as ENVIRONMENT_NAME
+
+// $settings['updates_log_disabled'] = TRUE;


Let's not bring that double negation variable into the template! Instead, let's implement config_split properly either via config or recipes.

tormi · 2024-04-18T21:21:48Z

This requires removal of basic profile, see also #403.

ragnarkurmwunder added 2 commits March 21, 2023 17:01

Modules: Config Split, Updates Log: Add

219a73b

Settings: Update. Remove Warden, Add UpdatesLog.

28870fe

ragnarkurmwunder requested review from tormi and hkirsman March 21, 2023 15:20

hkirsman reviewed Oct 4, 2023

View reviewed changes

tormi requested changes Dec 27, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Config Split and Updates Log #348

Add Config Split and Updates Log #348

ragnarkurmwunder commented Mar 21, 2023

misterjoonas commented Mar 22, 2023 •

edited

hkirsman Oct 4, 2023

tormi Dec 27, 2023

hkirsman Oct 4, 2023 •

edited

tormi Apr 19, 2024

hkirsman Oct 4, 2023 •

edited

tormi Dec 27, 2023

tormi left a comment

tormi Dec 27, 2023

tormi Dec 27, 2023

tormi Dec 27, 2023

tormi Dec 27, 2023

tormi Dec 27, 2023

tormi Dec 27, 2023

tormi Dec 27, 2023

tormi Dec 27, 2023

tormi commented Apr 18, 2024

Add Config Split and Updates Log #348

Are you sure you want to change the base?

Add Config Split and Updates Log #348

Conversation

ragnarkurmwunder commented Mar 21, 2023

misterjoonas commented Mar 22, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hkirsman Oct 4, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hkirsman Oct 4, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tormi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tormi commented Apr 18, 2024

misterjoonas commented Mar 22, 2023 •

edited

hkirsman Oct 4, 2023 •

edited

hkirsman Oct 4, 2023 •

edited