Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support work over proxy HTTP/HTTPS/SOCKS #948

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

iwojim0
Copy link

@iwojim0 iwojim0 commented Mar 9, 2024

#947

  • added possibility use http_proxy environment variable
  • for overlay networks also need increase timeout for http requests

@thebaer thebaer linked an issue Apr 17, 2024 that may be closed by this pull request
@thebaer
Copy link
Member

thebaer commented Apr 17, 2024

Thanks for submitting this! My main concern here is that each outgoing request to an ActivityPub server happens in sequence, so any slow server will hold up other requests as they're going out to the fediverse. With this change, it could be even slower than before.

I think to resolve this, we'd need to either change how requests go out (i.e. send them in parallel), or make this configurable somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

support work over proxy HTTP/HTTPS/SOCKS
2 participants