Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: properly implement bearer token authentication and function calling convention for plot_scan_strategy #653

Merged
merged 2 commits into from Nov 3, 2023
Merged

FIX: properly implement bearer token authentication and function calling convention for plot_scan_strategy #653

merged 2 commits into from Nov 3, 2023

Conversation

kmuehlbauer
Copy link
Member

@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (13935f0) 87.57% compared to head (d62de91) 87.24%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
- Coverage   87.57%   87.24%   -0.34%     
==========================================
  Files          56       56              
  Lines        9569     9572       +3     
==========================================
- Hits         8380     8351      -29     
- Misses       1189     1221      +32
Flag Coverage Δ
unittests 87.24% <50.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wradlib/vis.py 90.71% <0.00%> (-0.82%) ⬇️
wradlib/io/dem.py 58.51% <54.54%> (+6.86%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmuehlbauer kmuehlbauer changed the title FIX: plot_scan_strategy FIX: properly implement bearer token authentication adn function calling convention for plot_scan_strategy Nov 3, 2023
@kmuehlbauer kmuehlbauer changed the title FIX: properly implement bearer token authentication adn function calling convention for plot_scan_strategy FIX: properly implement bearer token authentication and function calling convention for plot_scan_strategy Nov 3, 2023
@kmuehlbauer kmuehlbauer merged commit a49d120 into wradlib:main Nov 3, 2023
12 of 14 checks passed
@kmuehlbauer kmuehlbauer deleted the fix-srtm branch November 3, 2023 11:11
@kmuehlbauer kmuehlbauer mentioned this pull request Nov 3, 2023
Closed
kmuehlbauer added a commit that referenced this pull request Nov 3, 2023
@kmuehlbauer
FIX: properly implement bearer token authentication and function call…
0846d3b 
…ing convention for plot_scan_strategy (#653)

(cherry picked from commit a49d120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kmuehlbauer