Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid theme config causing issues with custom properties/media #611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix invalid theme config causing issues with custom properties/media #611

wants to merge 1 commit into from

Conversation

felixarntz
Copy link
Contributor

Description

The default values for custom-media and custom-properties in config.default.json are not valid:

  • They each should be an object with a preserve property (see gulp/styles.js).
  • The preserve value for custom-media should default to false because basically no browser today supports that.

List of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • This pull request relates to a ticket.
  • This code is tested.
  • This change has been added to CHANGELOG.md
  • I want my code added to WP Rig.

@felixarntz felixarntz added the bug Something isn't working label Sep 28, 2019
@felixarntz felixarntz added this to the v2.0.2 milestone Sep 28, 2019
@felixarntz felixarntz added css gulp Gulp related issues labels Sep 28, 2019
@robruiz robruiz mentioned this pull request Dec 30, 2020
Merged
3 tasks
Base automatically changed from develop to master December 30, 2020 05:00
@robruiz
Copy link
Contributor

robruiz commented Nov 6, 2022

I'm interested to know if this is still a valid concern/contribution? I don't know enough about the context here to make a judgement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitchantre benoitchantre benoitchantre approved these changes

@ataylorme ataylorme ataylorme approved these changes

@bamadesigner bamadesigner Awaiting requested review from bamadesigner

@mor10 mor10 Awaiting requested review from mor10

Assignees
No one assigned
Labels
bug Something isn't working css gulp Gulp related issues
Projects
None yet
Milestone
v2.0.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixarntz @robruiz @benoitchantre @ataylorme