Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds has-sidebar class dynamically #558

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adds has-sidebar class dynamically #558

wants to merge 3 commits into from

Conversation

benoitchantre
Copy link
Contributor

@benoitchantre benoitchantre commented Jul 17, 2019 •
edited

Description

Addresses issue #331, #461.

Adds has-sidebar class to <body> based on get_sidebar() calls found in the current template (doesn't look in template parts).

List of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • This pull request relates to a ticket.
  • This code is tested.
  • This change has been added to CHANGELOG.md
  • I want my code added to WP Rig.

@benoitchantre benoitchantre mentioned this pull request Jul 17, 2019
Open
@benoitchantre benoitchantre self-assigned this Jul 17, 2019
@benoitchantre benoitchantre added enhancement New feature or request php labels Jul 17, 2019
@benoitchantre benoitchantre changed the base branch from master to develop July 17, 2019 20:04
@mor10 mor10 added this to the v2.1 milestone Aug 22, 2019
Base automatically changed from develop to master December 30, 2020 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bamadesigner bamadesigner Awaiting requested review from bamadesigner

@felixarntz felixarntz Awaiting requested review from felixarntz

@mor10 mor10 Awaiting requested review from mor10

Assignees

@benoitchantre benoitchantre

Labels
enhancement New feature or request needs-testing php
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benoitchantre @mor10