Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abseil-cpp as a 3rd party library #6610

Open
pjreiniger opened this issue May 11, 2024 · 1 comment
Open

Add abseil-cpp as a 3rd party library #6610

pjreiniger opened this issue May 11, 2024 · 1 comment

Comments

@pjreiniger
Copy link
Contributor

I wanted to upgrade protobuf as the more recent versions have better bazel support. The currently vendor'd version is from 9/22. Moving to a more recent release requires a dependency on abseil-cpp. I saw the #6607 and #6609, which also refer to abseil, albeit in a cmake case.

I'm happy to do the work, I just wanted approval for such a change before spending time on it.

@PeterJohnson
Copy link
Member

PeterJohnson commented May 11, 2024

Other than the fact I hate abseil with the flame of 1000 suns because it is the definition of dependency hell, if we have to upgrade, we have to upgrade. Can we at least build it all into a single library rather than the 50+ individual libraries it seems to have in distributions? Could we even bundle it all together with the protobuf thirdparty library (like how we do imgui)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants