- changes commentTypeNotIn field to a listOf String instead of String

[jasonbahl]

What does this implement/fix? Explain your changes.

This changes the commentTypeNotIn field on Comment connections to be a list_of => string type instead of a string type.

Does this close any currently open issues?

closes #2321

Any other comments?

This is a breaking change, as queries that were written like so:

query getComments( $notIn: String ) {
  comments( where: { commentTypeNotIn: $notIn ) {
    ...
  }
}

would need to be changed like so:

query getComments( $notIn: [String] ) { # <-- note the change to the variable declaration
  comments( where: { commentTypeNotIn: $notIn ) {
    ...
  }
}

Breaking Change

This includes a minor breaking change to the Schema, as seen here: https://github.com/wp-graphql/wp-graphql/runs/5823051931?check_suite_focus=true

Should you need to keep backward compatibility with the previous shape of the commentTypeNotIn field, this snippet will change the field back to a string instead of a listOf( string )

add_filter( 'graphql_input_fields', function( $fields, $type_name, $config, $type_registry ) {

	if ( ! array_key_exists( 'commentTypeNotIn', $fields ) ) {
		return $fields;
	}

	$fields['commentTypeNotIn']['type'] = 'String';

	return $fields;

}, 10, 4 );

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because it has not had recent activity. If you believe this issue is still valid, please open a new issue and mark this as a related issue.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because it has not had recent activity. If you believe this issue is still valid, please open a new issue and mark this as a related issue.