Register comments connection on NodeWithComments

[chriszarate]

What does this implement/fix? Explain your changes.

Register comments connection on NodeWithComments interface instead of one individual post types.

Does this close any currently open issues?

n/a

Any relevant logs, error output, GraphiQL screenshots, etc?

n/a

Any other comments?

I like interfaces. :)

Where has this been tested?

*Operating System: macOS

WordPress Version: 5.9

[codeclimate]

Code Climate has analyzed commit fa5cb24 and detected 0 issues on this pull request.

View more on Code Climate.

[coveralls]

Coverage decreased (-0.005%) to 79.256% when pulling fa5cb24 on chriszarate:fix/comments-registration-on-interface into 70dc88b on wp-graphql:develop.

[jasonbahl]

@chriszarate thanks for the PR!

I ultimately want to get here!

What I think needs to happen, still, is that Connections from/to Interfaces need to be able to also register edge Types for the specific relationships.

For example, if we were to have a generic ContentNode -> Term connection, then the following Types should also be generated in the Schema:

Types for the generic connection

• ContentNodeToTermConnection
• ContentNodeToTermConnectionEdge

Specific Types for the specific connections

• PostToTagConnection implements ContentNodeToTermConnection
• PostToTermConnectionEdge implements ContentNodeToTermConnectionEdge
• PostToCategoryConnection implements ContentNodeToTermConnection
• PostToCategoryConnectionEdge implements ContentNodeToTermConnectionEdge

---

This allows for Specific relationships to have specific edge data exposed in the Schema.

For example, if we had some relational data only between Pages and Comments but not other post types, with the current PR we would have to expose the edge data to all ContentNode -> Comments connections, which would be inaccurate.

I believe #1738 starts laying some of this ground work, but there's definitely more work to do in the Connections realm to get to this final destination.

Happy to chat more about it and see what we can do to get there.

Would be 🔥 to have the register_graphql_connection API do most of this work with little-to-no change to the registration of connections.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because it has not had recent activity. If you believe this issue is still valid, please open a new issue and mark this as a related issue.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because it has not had recent activity. If you believe this issue is still valid, please open a new issue and mark this as a related issue.