Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Fix inconsistencies API in graphql_map_input_fields_to_wp_q… #1664

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

galanggg
Copy link
Contributor

@galanggg galanggg commented Jan 7, 2021

…uery

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • [:heavy_check_mark:] Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • [:heavy_check_mark:] Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

Fixing inconsistent API in graphql_map_input_fields_to_wp_query

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 18.04 (Bionic Beaver)

WordPress Version:

@coveralls
Copy link

coveralls commented Jan 7, 2021

Coverage Status

Coverage increased (+2.0%) to 82.031% when pulling ec32cf0 on galanggg:1588-Filter-API-Inconsistencies into cf6118d on wp-graphql:develop.

@jasonbahl
Copy link
Collaborator

@galanggg this would be a breaking change. Can you elaborate in why you feel like this is needed?

@galanggg
Copy link
Contributor Author

galanggg commented Jan 7, 2021

Hi @jasonbahl , i'm so sorry. Because I thought that initially the position of this field was changed according to graphql_map_input_fields*.

refer to this issue #1588

@stale
Copy link

stale bot commented Aug 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 2, 2022
@stale
Copy link

stale bot commented Sep 1, 2022

This issue has been automatically closed because it has not had recent activity. If you believe this issue is still valid, please open a new issue and mark this as a related issue.

@stale stale bot closed this Sep 1, 2022
@justlevine justlevine reopened this Sep 2, 2022
@stale stale bot removed the stale label Sep 2, 2022
@justlevine justlevine added the Compat: Breaking Change This is a breaking change to existing functionality label Sep 24, 2022
@stale
Copy link

stale bot commented Dec 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale? May need to be revalidated due to prolonged inactivity label Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat: Breaking Change This is a breaking change to existing functionality Stale? May need to be revalidated due to prolonged inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants