Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for product_variation post type for ACF relationship resolver #471

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jacobarriola
Copy link
Contributor

Your checklist for this pull request

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

This PR adds a check for the product_variation post type when attempting to resolve the ACF relationship field. ACF allows for product_variations, so we need to support this post type should it come through.

Does this close any currently open issues?

#470

Where has this been tested?

  • WooGraphQL Version: 0.8.1
  • WPGraphQL Version: 1.1.8
  • WordPress Version: 5.7
  • WooCommerce Version: 4.9.2

@kidunot89
Copy link
Member

@jacobarriola The functionality this is trying to fix needs to be tested again to before the validity of the PR is confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants